georgew5656 commented on PR #14895: URL: https://github.com/apache/druid/pull/14895#issuecomment-1692158365
> Looks good. Left a minor comment. > > @georgew5656 , what would be the side effect of this if the `TaskQueue` is hypothetically slow in cleaning up finished tasks? The two things that will hang around for a while The completed K8s job/pod. I don't think this is a huge issue since its not actually consuming any resources (basically a key/value entry in etcd). The entry in the tasks map. The API call for listing tasks will still return this value and some of the task slot metrics will report the task as still running. New tasks will still be able to be run since the thread executing the future for the task will have completed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
