writer-jill commented on PR #14922: URL: https://github.com/apache/druid/pull/14922#issuecomment-1699181512
> This is great! I'm glad to see this and all the new great resources it mentions too! A few possible, hopefully constructive, comments: > > line 87 says "Avoid using non-equal filters because they're very resource-intensive." Then the example has a non-equal filter on time, which is normal (and an equal filter on product). Should it say something like "Avoid using non-equal filters when possible, because they're very resource-intensive"? > > The query on lines 105/106 doesn't filter on time. Since we want to encourage that, should it add something like eg AND __time BETWEEN '2016-06-27 00:00' AND '2016-06-27 12:00' just to encourage filtering on time when possible? > > For line 144, "Find out whether your dataset is already partitioned by user ID", I'm not sure what to do after I find that out, or how knowing helps or changes my options. > > For line 146 and 148, "granularity" is a loaded word for druid (query granularity being something else then meant here). Maybe something like "Query over smaller intervals" and "Consider whether you can query a smaller time interval"? > > line 194, is "__time" BETWEEN [] and [] on purpose? Should there be dates in there (like in my example above)? Addressed all of these issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
