kfaraz commented on code in PR #14932:
URL: https://github.com/apache/druid/pull/14932#discussion_r1311133771
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java:
##########
@@ -524,19 +523,16 @@ public static Function<Set<DataSegment>,
Set<DataSegment>> compactionStateAnnota
? null
: new
DimensionsSpec(ingestionSpec.getDataSchema().getDimensionsSpec().getDimensions());
// We only need to store filter since that is the only field auto
compaction support
- Map<String, Object> transformSpec =
ingestionSpec.getDataSchema().getTransformSpec() == null ||
TransformSpec.NONE.equals(ingestionSpec.getDataSchema().getTransformSpec())
+ TransformSpec transformSpec =
ingestionSpec.getDataSchema().getTransformSpec() == null ||
TransformSpec.NONE.equals(ingestionSpec.getDataSchema().getTransformSpec())
Review Comment:
Nit: Pull `ingestionSpec.getDataSchema().getTransformSpec()` into a
variable. It is used thrice and seems too verbose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
