clintropolis commented on code in PR #14932:
URL: https://github.com/apache/druid/pull/14932#discussion_r1312091958
##########
processing/src/main/java/org/apache/druid/timeline/CompactionState.java:
##########
@@ -43,27 +46,21 @@ public class CompactionState
{
private final PartitionsSpec partitionsSpec;
private final DimensionsSpec dimensionsSpec;
- // org.apache.druid.segment.transform.TransformSpec cannot be used here
because it's in the 'processing' module which
- // has a dependency on the 'core' module where this class is.
- private final Map<String, Object> transformSpec;
- // org.apache.druid.segment.IndexSpec cannot be used here because it's in
the 'processing' module which
- // has a dependency on the 'core' module where this class is.
- private final Map<String, Object> indexSpec;
+ private final TransformSpec transformSpec;
+ private final IndexSpec indexSpec;
// org.apache.druid.segment.indexing.granularity.GranularitySpec cannot be
used here because it's in the
- // 'server' module which has a dependency on the 'core' module where this
class is.
- private final Map<String, Object> granularitySpec;
- // org.apache.druid.query.aggregation.AggregatorFactory cannot be used here
because it's in the 'processing' module which
- // has a dependency on the 'core' module where this class is.
- private final List<Object> metricsSpec;
+ // 'server' module which has a dependency on the 'processing' module where
this class is.
Review Comment:
oops, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
