kfaraz commented on code in PR #14829:
URL: https://github.com/apache/druid/pull/14829#discussion_r1312586248
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopIndexTask.java:
##########
@@ -529,7 +529,10 @@ private TaskStatus runInternal(TaskToolbox toolbox) throws
Exception
indexerGeneratorCleanupJob(
indexGeneratorJobAttempted,
indexGeneratorJobSuccess,
- indexerSchema == null ? null :
toolbox.getJsonMapper().writeValueAsString(indexerSchema)
+ indexerSchema == null ? null :
toolbox.getJsonMapper().writeValueAsString(
+ indexerSchema.withTuningConfig(
+ indexerSchema.getTuningConfig().withVersion(
+ version == null ?
indexerSchema.getTuningConfig().getVersion() : version)))
Review Comment:
Might be nicer to move all of this logic inside the
`indexerGeneratorCleanupJob` and just pass the `version` and the
`indexerSchema` itself to that method rather than a String.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
