capistrant commented on code in PR #14829:
URL: https://github.com/apache/druid/pull/14829#discussion_r1320212949
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopIndexTask.java:
##########
@@ -529,7 +529,10 @@ private TaskStatus runInternal(TaskToolbox toolbox) throws
Exception
indexerGeneratorCleanupJob(
indexGeneratorJobAttempted,
indexGeneratorJobSuccess,
- indexerSchema == null ? null :
toolbox.getJsonMapper().writeValueAsString(indexerSchema)
+ indexerSchema == null ? null :
toolbox.getJsonMapper().writeValueAsString(
+ indexerSchema.withTuningConfig(
+ indexerSchema.getTuningConfig().withVersion(
+ version == null ?
indexerSchema.getTuningConfig().getVersion() : version)))
Review Comment:
I cleaned it up a bit by handling the schema update with a new version above
this in the code. I think it makes things more readable and avoids refactoring
the indexerGeneratorCleanupJob. Let me know what you think. I will have to
address the coverage in an additional commit once I have a few minutes to look
at the tests that exist already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
