clintropolis commented on code in PR #14943:
URL: https://github.com/apache/druid/pull/14943#discussion_r1322222267
##########
processing/src/main/java/org/apache/druid/math/expr/BuiltInExprMacros.java:
##########
@@ -144,4 +145,47 @@ public Object getLiteralValue()
}
}
}
+
+ public static class StringDecodeBase64UTFExprMacro implements
ExprMacroTable.ExprMacro
Review Comment:
`BaseScalarUnivariateMacroFunctionExpr` is the macro version of right thing
to extend here since this is a single arugment function, +1 for re-using it
since it would simplify things a bit here
##########
processing/src/main/java/org/apache/druid/math/expr/ExprMacroTable.java:
##########
@@ -44,7 +44,8 @@
public class ExprMacroTable
{
private static final List<ExprMacro> BUILT_IN = ImmutableList.of(
- new BuiltInExprMacros.ComplexDecodeBase64ExprMacro()
+ new BuiltInExprMacros.ComplexDecodeBase64ExprMacro(),
+ new BuiltInExprMacros.StringDecodeBase64UTFExprMacro()
Review Comment:
that would fix the SQL layer, but this is native expression macros, which do
not currently have a generic aliasing thing here.
@pranavbhole what are your plans for this aliasing? (I just want to make
sure this actually gets done whether or not in this PR, and not lost)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
