github-code-scanning[bot] commented on code in PR #15012:
URL: https://github.com/apache/druid/pull/15012#discussion_r1331012134
##########
processing/src/main/java/org/apache/druid/query/dimension/ListFilteredDimensionSpec.java:
##########
@@ -79,9 +79,9 @@
}
if (isWhitelist) {
- return filterAllowList(values, selector);
+ return filterAllowList(values, selector, delegate.getExtractionFn() !=
null);
Review Comment:
## Deprecated method or constructor invocation
Invoking [DimensionSpec.getExtractionFn](1) should be avoided because it has
been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5802)
##########
processing/src/main/java/org/apache/druid/segment/virtual/ListFilteredVirtualColumn.java:
##########
@@ -136,9 +137,9 @@
)
{
if (allowList) {
- return ListFilteredDimensionSpec.filterAllowList(values,
factory.makeDimensionSelector(delegate));
+ return ListFilteredDimensionSpec.filterAllowList(values,
factory.makeDimensionSelector(delegate), delegate.getExtractionFn() != null);
Review Comment:
## Deprecated method or constructor invocation
Invoking [DimensionSpec.getExtractionFn](1) should be avoided because it has
been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5804)
##########
processing/src/main/java/org/apache/druid/query/dimension/ListFilteredDimensionSpec.java:
##########
@@ -79,9 +79,9 @@
}
if (isWhitelist) {
- return filterAllowList(values, selector);
+ return filterAllowList(values, selector, delegate.getExtractionFn() !=
null);
} else {
- return filterDenyList(values, selector);
+ return filterDenyList(values, selector, delegate.getExtractionFn() !=
null);
Review Comment:
## Deprecated method or constructor invocation
Invoking [DimensionSpec.getExtractionFn](1) should be avoided because it has
been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5803)
##########
processing/src/main/java/org/apache/druid/segment/virtual/ListFilteredVirtualColumn.java:
##########
@@ -136,9 +137,9 @@
)
{
if (allowList) {
- return ListFilteredDimensionSpec.filterAllowList(values,
factory.makeDimensionSelector(delegate));
+ return ListFilteredDimensionSpec.filterAllowList(values,
factory.makeDimensionSelector(delegate), delegate.getExtractionFn() != null);
} else {
- return ListFilteredDimensionSpec.filterDenyList(values,
factory.makeDimensionSelector(delegate));
+ return ListFilteredDimensionSpec.filterDenyList(values,
factory.makeDimensionSelector(delegate), delegate.getExtractionFn() != null);
Review Comment:
## Deprecated method or constructor invocation
Invoking [DimensionSpec.getExtractionFn](1) should be avoided because it has
been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5805)
##########
processing/src/main/java/org/apache/druid/segment/virtual/ListFilteredVirtualColumn.java:
##########
@@ -182,6 +183,9 @@
@Override
public ColumnIndexSupplier getIndexSupplier(String columnName,
ColumnSelector columnSelector)
{
+ if (delegate.getExtractionFn() != null) {
Review Comment:
## Deprecated method or constructor invocation
Invoking [DimensionSpec.getExtractionFn](1) should be avoided because it has
been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5806)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
