cryptoe commented on code in PR #15000: URL: https://github.com/apache/druid/pull/15000#discussion_r1331338534
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/SegmentLoadStatusFetcher.java: ########## @@ -90,11 +94,15 @@ public class SegmentLoadWaiter private final Set<String> versionsToAwait; private final int totalSegmentsGenerated; private final boolean doWait; + // since live reports fetch the value in another thread, we need to use AtomicReference private final AtomicReference<SegmentLoadWaiterStatus> status; Review Comment: Not really The status is an internal class class So it think we can let it remain as it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
