cryptoe opened a new pull request, #15000:
URL: https://github.com/apache/druid/pull/15000
With PR #14322 , MSQ insert/Replace q's will wait for segment to be loaded
on the historical's before finishing.
The patch introduces a bug where in the main thread had a thread.sleep()
which could not be interuptted via the cancel calls from the overlord.
This new patch addressed that problem by moving the thread.sleep inside a
thread of its own. Thus the main thread is now waiting on the future object of
this execution.
The cancel call can now shutdown the executor service via another method
thus unblocking the main thread to proceed.
This PR has:
- [ x been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [x] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [x] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
