gianm commented on code in PR #15010:
URL: https://github.com/apache/druid/pull/15010#discussion_r1331814509
##########
.github/workflows/static-checks.yml:
##########
@@ -56,6 +56,12 @@ jobs:
run: |
echo "JAVA_HOME=$JAVA_HOME_${{ env.java_version }}_X64" >>
$GITHUB_ENV
+ - name: Cache Maven packages
Review Comment:
Because we have a `matrix` of `java`, should we include `${{ matrix.java }}`
in the cache key? I'm not sure if the `java` versions matters for what `mvn`
does, but, it might…?
I also wonder if we can use `actions/setup-java` with `cache: 'maven'`,
which according to documentation
(https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#about-caching-workflow-dependencies)
automatically configures caching with the appropriate variables.
##########
.github/workflows/static-checks.yml:
##########
@@ -56,6 +56,12 @@ jobs:
run: |
echo "JAVA_HOME=$JAVA_HOME_${{ env.java_version }}_X64" >>
$GITHUB_ENV
+ - name: Cache Maven packages
Review Comment:
Because we have a `matrix` of `java`, should we include `${{ matrix.java }}`
in the cache key? I'm not sure if the `java` versions matters for what `mvn`
does, but, it might…?
I also wonder if we can use `actions/setup-java` with `cache: 'maven'`,
which according to documentation
(https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#about-caching-workflow-dependencies)
automatically configures caching with the appropriate variables.
##########
.github/workflows/static-checks.yml:
##########
@@ -56,6 +56,12 @@ jobs:
run: |
echo "JAVA_HOME=$JAVA_HOME_${{ env.java_version }}_X64" >>
$GITHUB_ENV
+ - name: Cache Maven packages
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: maven-static-checks-${{ matrix.java }}-${{
hashFiles('**/pom.xml') }}
Review Comment:
Is there a reason to have these jobs all use different cache keys --
could/should they share a cache?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
