somu-imply commented on code in PR #14886:
URL: https://github.com/apache/druid/pull/14886#discussion_r1331913761
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/DataSourcePlan.java:
##########
@@ -137,6 +139,30 @@ public static DataSourcePlan forDataSource(
} else if (dataSource instanceof LookupDataSource) {
checkQuerySegmentSpecIsEternity(dataSource, querySegmentSpec);
return forLookup((LookupDataSource) dataSource, broadcast);
+ } else if (dataSource instanceof FilteredDataSource) {
+ checkQuerySegmentSpecIsEternity(dataSource, querySegmentSpec);
+ return forFilteredDataSource(
+ queryKit,
+ queryId,
+ queryContext,
+ (FilteredDataSource) dataSource,
+ querySegmentSpec,
+ maxWorkerCount,
+ minStageNumber,
+ broadcast
+ );
+ } else if (dataSource instanceof UnnestDataSource) {
+ checkQuerySegmentSpecIsEternity(dataSource, querySegmentSpec);
Review Comment:
Based on the UTs I ran, this can be removed for the top-level UnnestDS and
FilteredDS, as the inner calls of `forDataSource` on the base data sources will
validate this. For example, if the base is a query data source that needs the
check, the recursive call will take care of it on the base. Hence I removed this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
