LakshSingla commented on code in PR #14886:
URL: https://github.com/apache/druid/pull/14886#discussion_r1332488690
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/DataSourcePlan.java:
##########
@@ -347,6 +370,92 @@ private static DataSourcePlan forQuery(
);
}
+ private static DataSourcePlan forFilteredDataSource(
+ final QueryKit queryKit,
+ final String queryId,
+ final QueryContext queryContext,
+ final FilteredDataSource dataSource,
+ final QuerySegmentSpec querySegmentSpec,
+ final int maxWorkerCount,
+ final int minStageNumber,
+ final boolean broadcast
+ )
+ {
+ final QueryDefinitionBuilder subQueryDefBuilder =
QueryDefinition.builder();
+ final DataSourcePlan basePlan = forDataSource(
+ queryKit,
+ queryId,
+ queryContext,
+ dataSource.getBase(),
+ querySegmentSpec,
+ null,
+ maxWorkerCount,
+ Math.max(minStageNumber, subQueryDefBuilder.getNextStageNumber()),
+ broadcast
+ );
+
+ DataSource newDataSource = basePlan.getNewDataSource();
+ basePlan.getSubQueryDefBuilder().ifPresent(subQueryDefBuilder::addAll);
+
+ final List<InputSpec> inputSpecs = new
ArrayList<>(basePlan.getInputSpecs());
+ newDataSource = FilteredDataSource.create(newDataSource,
dataSource.getFilter());
+ return new DataSourcePlan(
+ newDataSource,
+ inputSpecs,
+ basePlan.getBroadcastInputs(),
+ subQueryDefBuilder
+ );
+
+ }
+
+ /**
+ * Build a plan for Unnest data source
+ */
+ private static DataSourcePlan forUnnest(
+ final QueryKit queryKit,
+ final String queryId,
+ final QueryContext queryContext,
+ final UnnestDataSource dataSource,
+ final QuerySegmentSpec querySegmentSpec,
+ final int maxWorkerCount,
+ final int minStageNumber,
+ final boolean broadcast
+ )
+ {
+ final QueryDefinitionBuilder subQueryDefBuilder =
QueryDefinition.builder();
+ // Find the plan for base data source by recursing
+ final DataSourcePlan basePlan = forDataSource(
+ queryKit,
+ queryId,
+ queryContext,
+ dataSource.getBase(),
+ querySegmentSpec,
+ null,
+ maxWorkerCount,
+ Math.max(minStageNumber, subQueryDefBuilder.getNextStageNumber()),
Review Comment:
Also, thinking about it, we probably didn't need to create a separate
subqueryDefBuilder since we aren't adding a new stage anyway, we can pass in
the same one to the recursive call which might be causing this confusion. Since
there are a few changes pending, let's clean this up as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
