georgew5656 commented on code in PR #14887:
URL: https://github.com/apache/druid/pull/14887#discussion_r1334682414
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/taskadapter/K8sTaskAdapter.java:
##########
@@ -433,5 +475,18 @@ static ResourceRequirements
getResourceRequirements(ResourceRequirements require
}
return requirements;
}
+
+ @Override
+ public Boolean shouldUseDeepStorageForTaskPayload(Task task)
+ {
+ try {
+ String compressedTaskPayload =
Base64Compression.compressBase64(mapper.writeValueAsString(task));
+ return compressedTaskPayload.length() >
DruidK8sConstants.MAX_ENV_VARIABLE_KBS;
+ }
+ catch (Exception e) {
Review Comment:
the compiler is forcing the call, but I guess we can make this method throw
IOException since all the other methods in the interface do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
