github-code-scanning[bot] commented on code in PR #14887:
URL: https://github.com/apache/druid/pull/14887#discussion_r1327741763
##########
services/src/main/java/org/apache/druid/cli/CliPeon.java:
##########
@@ -282,9 +290,15 @@
@Provides
@LazySingleton
- public Task readTask(@Json ObjectMapper mapper,
ExecutorLifecycleConfig config)
+ public Task readTask(@Json ObjectMapper mapper, @Smile ObjectMapper
smileMapper, ExecutorLifecycleConfig config, TaskPayloadManager
taskPayloadManager, TaskConfig taskConfig)
Review Comment:
## Useless parameter
The parameter 'smileMapper' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5795)
##########
services/src/main/java/org/apache/druid/cli/CliPeon.java:
##########
@@ -282,9 +290,15 @@
@Provides
@LazySingleton
- public Task readTask(@Json ObjectMapper mapper,
ExecutorLifecycleConfig config)
+ public Task readTask(@Json ObjectMapper mapper, @Smile ObjectMapper
smileMapper, ExecutorLifecycleConfig config, TaskPayloadManager
taskPayloadManager, TaskConfig taskConfig)
Review Comment:
## Useless parameter
The parameter 'taskConfig' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5796)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
