LakshSingla commented on PR #15020: URL: https://github.com/apache/druid/pull/15020#issuecomment-1732864728
I think there are cases when there are multiple `FilteredDataSources` stacked on top of each other directly or indirectly. For example -> FilteredDS -> UnnestDS -> FilteredDS -> UnnestDS. How would this code handle those cases, will it ignore the second UnnestedDS? What if the base table of the above chain has a filter of itself? (Is it possible in the first place?) If not then we should clearly highlight that assumption in the getFiltration method. Otherwise, it would be good if the code could handle cases like these automatically. Also, UNNEST on MSQ got merged so let's make sure that the tests pass with them and we prune the segments properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
