LakshSingla commented on PR #15020: URL: https://github.com/apache/druid/pull/15020#issuecomment-1734217183
Let's note this comment somewhere as the assumption while optimizing the filter. This might not be intuitive for someone who is just messing with that part of the code, and since its implicitly baked into the code, it would be good to add it as a comment. Also, if we can, then let's add a check that there is no multiple nesting of the filtered data sources. This shouldn't take extra runtime, and at the cost of increased code complexity, we make sure that the queries don't silently pass with incorrect pruning like earlier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
