georgew5656 commented on code in PR #15033:
URL: https://github.com/apache/druid/pull/15033#discussion_r1337440641
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesAndWorkerTaskRunner.java:
##########
@@ -232,6 +233,16 @@ public Optional<InputStream> streamTaskLog(String taskid,
long offset) throws IO
return Optional.absent();
}
+ @Override
+ public TaskLocation getTaskLocation(String taskId)
+ {
+ TaskLocation taskLocation = kubernetesTaskRunner.getTaskLocation(taskId);
Review Comment:
i feel it really probably shouldn't show an exception b/c this is the logic
final KubernetesWorkItem workItem = tasks.get(taskId);
if (workItem == null) {
return TaskLocation.unknown();
} else {
return workItem.getLocation();
}
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesAndWorkerTaskRunner.java:
##########
@@ -232,6 +233,16 @@ public Optional<InputStream> streamTaskLog(String taskid,
long offset) throws IO
return Optional.absent();
}
+ @Override
+ public TaskLocation getTaskLocation(String taskId)
+ {
+ TaskLocation taskLocation = kubernetesTaskRunner.getTaskLocation(taskId);
Review Comment:
i feel it really probably shouldn't throw an exception b/c this is the logic
final KubernetesWorkItem workItem = tasks.get(taskId);
if (workItem == null) {
return TaskLocation.unknown();
} else {
return workItem.getLocation();
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
