georgew5656 commented on code in PR #15033:
URL: https://github.com/apache/druid/pull/15033#discussion_r1337441556


##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesAndWorkerTaskRunner.java:
##########
@@ -232,6 +233,16 @@ public Optional<InputStream> streamTaskLog(String taskid, 
long offset) throws IO
     return Optional.absent();
   }
 
+  @Override
+  public TaskLocation getTaskLocation(String taskId)
+  {
+    TaskLocation taskLocation = kubernetesTaskRunner.getTaskLocation(taskId);

Review Comment:
   i feel like its fine to propagate an exception up b/c something is probably 
v wrong if it does throw one



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to