somu-imply commented on code in PR #15034:
URL: https://github.com/apache/druid/pull/15034#discussion_r1337519424
##########
processing/src/main/java/org/apache/druid/math/expr/BuiltInExprMacros.java:
##########
@@ -25,20 +25,28 @@
import javax.annotation.Nullable;
import java.util.Collections;
import java.util.List;
+import java.util.Optional;
import java.util.stream.Collectors;
public class BuiltInExprMacros
{
public static class ComplexDecodeBase64ExprMacro implements
ExprMacroTable.ExprMacro
{
public static final String NAME = "complex_decode_base64";
+ public static final String ALIAS_NAME = "decode_base64_complex";
Review Comment:
If we change this alias in the future is there a way to maintain backward
compatibility?
Also, we might want to add native tests with the alias name to ensure the
correctness
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
