gianm commented on PR #15035: URL: https://github.com/apache/druid/pull/15035#issuecomment-1737981043
It seems that the intent here is to prevent sampling from Kafka getting stuck when fewer than `numRows` exist in the stream. Instead of adding a second shorter timeout, could we tackle that problem directly? Something like having the sampler check the latest offset available in Kafka first (using `RecordSupplier#getLatestSequenceNumber`) and then returning early once it has read up through that latest message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
