zachjsh opened a new pull request, #15035:
URL: https://github.com/apache/druid/pull/15035
### Description
Previously, when sampling streaming data, the sampler would wait `timeoutMs`
for `numRows` to be returned. If the stream has less rows than `numRows`, the
sampler would wait the full `timeoutMs` period. In some cases, initially
connecting to a given stream to sample may take a considerable amount of time,
but reading subsequent records thereafter is a much faster operation. For these
cases, this PR adds a new sampler config property `nextRecordTimeoutMs`, which
if specified, causes the sampler to return after this period of time if no
further records are found between the last record found, or `timeoutMs`,
whichever comes first. For example if a stream has only 1 record in it at a
given time, and `timeoutMs` is configured as `15000` miliseconds and
`nextRecordTimeoutMs` is configured as `2000` milliseconds while `numRows` is
configured as `500`, then assuming the first record is read quickly, the
sampler will return after roughly `2000` milliseconds, whereas previously it
would ha
ve returned after the full `15000` millesecond `timeoutMs` config value.
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
