LakshSingla commented on PR #15025: URL: https://github.com/apache/druid/pull/15025#issuecomment-1744353274
> Though seems like Laksh has objections to injecting pool into a monitor. I will let him chime in too. I had concerns with the monitor directly interacting with the merge buffer pool, instead of the stats provider that it was supposed to work with. However, I don't have a strong stance on the same, since its mostly internal implementation. The changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
