kaisun2000 commented on code in PR #15025:
URL: https://github.com/apache/druid/pull/15025#discussion_r1344798600
##########
server/src/main/java/org/apache/druid/server/metrics/QueryCountStatsMonitor.java:
##########
@@ -21,24 +21,30 @@
import com.google.common.collect.ImmutableMap;
import com.google.inject.Inject;
+import org.apache.druid.collections.BlockingPool;
+import org.apache.druid.guice.annotations.Merging;
import org.apache.druid.java.util.emitter.service.ServiceEmitter;
import org.apache.druid.java.util.emitter.service.ServiceMetricEvent;
import org.apache.druid.java.util.metrics.AbstractMonitor;
import org.apache.druid.java.util.metrics.KeyedDiff;
+import java.nio.ByteBuffer;
import java.util.Map;
public class QueryCountStatsMonitor extends AbstractMonitor
{
private final KeyedDiff keyedDiff = new KeyedDiff();
private final QueryCountStatsProvider statsProvider;
+ private final BlockingPool<ByteBuffer> mergeBufferPool;
@Inject
public QueryCountStatsMonitor(
- QueryCountStatsProvider statsProvider
+ QueryCountStatsProvider statsProvider,
+ @Merging BlockingPool<ByteBuffer> mergeBufferPoolIn
Review Comment:
to follow other code patterns, changed to
```
@Inject
public QueryCountStatsMonitor(
QueryCountStatsProvider statsProvider,
@Merging BlockingPool<ByteBuffer> mergeBufferPool
)
{
this.statsProvider = statsProvider;
this.mergeBufferPool = mergeBufferPool;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
