LakshSingla commented on code in PR #14900:
URL: https://github.com/apache/druid/pull/14900#discussion_r1344607747
##########
processing/src/main/java/org/apache/druid/frame/field/FieldReaders.java:
##########
@@ -61,8 +60,22 @@ public static FieldReader create(final String columnName,
final ColumnType colum
return ComplexFieldReader.createFromType(columnType);
case ARRAY:
- if (columnType.getElementType().getType() == ValueType.STRING) {
- return new StringFieldReader(true);
+ switch
(Preconditions.checkNotNull(columnType.getElementType().getType(), "array
elementType")) {
+ case STRING:
+ return new StringFieldReader(true);
Review Comment:
I have added a new namesake reader for this.
So, to create new methods would be:
1. `new StringFieldReader()` -> for strings
2. `new StringArrayFieldReader()` -> for string arrays
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
