LakshSingla commented on code in PR #14900:
URL: https://github.com/apache/druid/pull/14900#discussion_r1345484923
##########
sql/src/test/java/org/apache/druid/sql/calcite/QueryTestRunner.java:
##########
@@ -667,7 +674,9 @@ public QueryTestRunner(QueryTestBuilder builder)
verifySteps.add(new VerifyNativeQueries(finalExecStep));
}
if (builder.expectedResultsVerifier != null) {
- verifySteps.add(new VerifyResults(finalExecStep));
+ // Don't verify the row signature when MSQ is running, since the
broker receives the task id, and the signature
+ // would be {TASK:STRING} instead of the expected results signature
+ verifySteps.add(new VerifyResults(finalExecStep,
!config.isRunningMSQ()));
Review Comment:
Yep, I wanted to separate out the row signature check and the results check,
though chose not to keep it in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
