github-code-scanning[bot] commented on code in PR #15073:
URL: https://github.com/apache/druid/pull/15073#discussion_r1344746750
##########
sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidJoinWithUnnestOnLeftRule.java:
##########
@@ -0,0 +1,50 @@
+package org.apache.druid.sql.calcite.rule;
+
+import org.apache.calcite.plan.RelOptRule;
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.rel.core.Join;
+import org.apache.druid.sql.calcite.planner.PlannerContext;
+import org.apache.druid.sql.calcite.rel.DruidJoinUnnestRel;
+import org.apache.druid.sql.calcite.rel.DruidRel;
+import org.apache.druid.sql.calcite.rel.DruidUnnestRel;
+
+public class DruidJoinWithUnnestOnLeftRule extends RelOptRule
+{
+ private final PlannerContext plannerContext;
+ public DruidJoinWithUnnestOnLeftRule(PlannerContext plannerContext1)
+ {
+ super(
+ operand(
+ Join.class,
+ operand(DruidUnnestRel.class, any()),
+ operand(DruidRel.class, any())
+ )
+ );
+ this.plannerContext = plannerContext1;
+ }
+
+ @Override
+ public boolean matches(RelOptRuleCall call)
+ {
+ final Join join = call.rel(0);
Review Comment:
## Unread local variable
Variable 'Join join' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5850)
##########
sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidCorrelateUnnestRule.java:
##########
@@ -80,7 +84,7 @@
operand(
Correlate.class,
operand(DruidRel.class, any()),
- operand(DruidUnnestRel.class, any())
+ operand(DruidRel.class, any())
Review Comment:
## Deprecated method or constructor invocation
Invoking [RelOptRule.any](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5856)
##########
sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidCorrelateUnnestRule.java:
##########
@@ -80,7 +84,7 @@
operand(
Correlate.class,
operand(DruidRel.class, any()),
- operand(DruidUnnestRel.class, any())
+ operand(DruidRel.class, any())
Review Comment:
## Deprecated method or constructor invocation
Invoking [RelOptRule.operand](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5854)
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidJoinUnnestRel.java:
##########
@@ -0,0 +1,130 @@
+package org.apache.druid.sql.calcite.rel;
+
+import org.apache.calcite.plan.RelOptCluster;
+import org.apache.calcite.plan.RelTraitSet;
+import org.apache.calcite.rel.RelWriter;
+import org.apache.calcite.rel.core.Join;
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.druid.query.DataSource;
+import org.apache.druid.query.TableDataSource;
+import org.apache.druid.sql.calcite.planner.PlannerContext;
+import org.apache.druid.sql.calcite.table.RowSignatures;
+
+import javax.annotation.Nullable;
+import java.util.Collections;
+import java.util.Set;
+
+
+public class DruidJoinUnnestRel extends DruidRel<DruidJoinUnnestRel>
Review Comment:
## No clone method
No clone method, yet implements Cloneable.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5862)
##########
sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidJoinWithUnnestOnLeftRule.java:
##########
@@ -0,0 +1,50 @@
+package org.apache.druid.sql.calcite.rule;
+
+import org.apache.calcite.plan.RelOptRule;
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.rel.core.Join;
+import org.apache.druid.sql.calcite.planner.PlannerContext;
+import org.apache.druid.sql.calcite.rel.DruidJoinUnnestRel;
+import org.apache.druid.sql.calcite.rel.DruidRel;
+import org.apache.druid.sql.calcite.rel.DruidUnnestRel;
+
+public class DruidJoinWithUnnestOnLeftRule extends RelOptRule
+{
+ private final PlannerContext plannerContext;
+ public DruidJoinWithUnnestOnLeftRule(PlannerContext plannerContext1)
+ {
+ super(
+ operand(
+ Join.class,
+ operand(DruidUnnestRel.class, any()),
+ operand(DruidRel.class, any())
Review Comment:
## Deprecated method or constructor invocation
Invoking [RelOptRule.any](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5861)
##########
sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidJoinWithUnnestOnLeftRule.java:
##########
@@ -0,0 +1,50 @@
+package org.apache.druid.sql.calcite.rule;
+
+import org.apache.calcite.plan.RelOptRule;
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.rel.core.Join;
+import org.apache.druid.sql.calcite.planner.PlannerContext;
+import org.apache.druid.sql.calcite.rel.DruidJoinUnnestRel;
+import org.apache.druid.sql.calcite.rel.DruidRel;
+import org.apache.druid.sql.calcite.rel.DruidUnnestRel;
+
+public class DruidJoinWithUnnestOnLeftRule extends RelOptRule
+{
+ private final PlannerContext plannerContext;
+ public DruidJoinWithUnnestOnLeftRule(PlannerContext plannerContext1)
+ {
+ super(
+ operand(
+ Join.class,
+ operand(DruidUnnestRel.class, any()),
Review Comment:
## Deprecated method or constructor invocation
Invoking [RelOptRule.any](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5860)
##########
sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidJoinWithUnnestOnLeftRule.java:
##########
@@ -0,0 +1,50 @@
+package org.apache.druid.sql.calcite.rule;
+
+import org.apache.calcite.plan.RelOptRule;
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.rel.core.Join;
+import org.apache.druid.sql.calcite.planner.PlannerContext;
+import org.apache.druid.sql.calcite.rel.DruidJoinUnnestRel;
+import org.apache.druid.sql.calcite.rel.DruidRel;
+import org.apache.druid.sql.calcite.rel.DruidUnnestRel;
+
+public class DruidJoinWithUnnestOnLeftRule extends RelOptRule
+{
+ private final PlannerContext plannerContext;
+ public DruidJoinWithUnnestOnLeftRule(PlannerContext plannerContext1)
+ {
+ super(
+ operand(
+ Join.class,
+ operand(DruidUnnestRel.class, any()),
+ operand(DruidRel.class, any())
+ )
Review Comment:
## Deprecated method or constructor invocation
Invoking [RelOptRule.operand](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5857)
##########
sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidJoinWithUnnestOnLeftRule.java:
##########
@@ -0,0 +1,50 @@
+package org.apache.druid.sql.calcite.rule;
+
+import org.apache.calcite.plan.RelOptRule;
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.rel.core.Join;
+import org.apache.druid.sql.calcite.planner.PlannerContext;
+import org.apache.druid.sql.calcite.rel.DruidJoinUnnestRel;
+import org.apache.druid.sql.calcite.rel.DruidRel;
+import org.apache.druid.sql.calcite.rel.DruidUnnestRel;
+
+public class DruidJoinWithUnnestOnLeftRule extends RelOptRule
+{
+ private final PlannerContext plannerContext;
+ public DruidJoinWithUnnestOnLeftRule(PlannerContext plannerContext1)
+ {
+ super(
+ operand(
+ Join.class,
+ operand(DruidUnnestRel.class, any()),
+ operand(DruidRel.class, any())
Review Comment:
## Deprecated method or constructor invocation
Invoking [RelOptRule.operand](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5859)
##########
sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidJoinWithUnnestOnLeftRule.java:
##########
@@ -0,0 +1,50 @@
+package org.apache.druid.sql.calcite.rule;
+
+import org.apache.calcite.plan.RelOptRule;
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.rel.core.Join;
+import org.apache.druid.sql.calcite.planner.PlannerContext;
+import org.apache.druid.sql.calcite.rel.DruidJoinUnnestRel;
+import org.apache.druid.sql.calcite.rel.DruidRel;
+import org.apache.druid.sql.calcite.rel.DruidUnnestRel;
+
+public class DruidJoinWithUnnestOnLeftRule extends RelOptRule
+{
+ private final PlannerContext plannerContext;
+ public DruidJoinWithUnnestOnLeftRule(PlannerContext plannerContext1)
+ {
+ super(
+ operand(
+ Join.class,
+ operand(DruidUnnestRel.class, any()),
Review Comment:
## Deprecated method or constructor invocation
Invoking [RelOptRule.operand](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5858)
##########
sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidJoinWithUnnestOnLeftRule.java:
##########
@@ -0,0 +1,50 @@
+package org.apache.druid.sql.calcite.rule;
+
+import org.apache.calcite.plan.RelOptRule;
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.rel.core.Join;
+import org.apache.druid.sql.calcite.planner.PlannerContext;
+import org.apache.druid.sql.calcite.rel.DruidJoinUnnestRel;
+import org.apache.druid.sql.calcite.rel.DruidRel;
+import org.apache.druid.sql.calcite.rel.DruidUnnestRel;
+
+public class DruidJoinWithUnnestOnLeftRule extends RelOptRule
+{
+ private final PlannerContext plannerContext;
+ public DruidJoinWithUnnestOnLeftRule(PlannerContext plannerContext1)
+ {
+ super(
+ operand(
+ Join.class,
+ operand(DruidUnnestRel.class, any()),
+ operand(DruidRel.class, any())
+ )
+ );
+ this.plannerContext = plannerContext1;
+ }
+
+ @Override
+ public boolean matches(RelOptRuleCall call)
+ {
+ final Join join = call.rel(0);
+ final DruidRel<?> left = call.rel(1);
Review Comment:
## Unread local variable
Variable 'DruidRel<?> left' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5851)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
