LakshSingla commented on code in PR #15076:
URL: https://github.com/apache/druid/pull/15076#discussion_r1346844280
##########
docs/multi-stage-query/reference.md:
##########
@@ -246,6 +246,7 @@ The following table lists the context parameters for the
MSQ task engine:
| `durableShuffleStorage` | SELECT, INSERT, REPLACE <br /><br />Whether to use
durable storage for shuffle mesh. To use this feature, configure the durable
storage at the server level using
`druid.msq.intermediate.storage.enable=true`). If these properties are not
configured, any query with the context variable `durableShuffleStorage=true`
fails with a configuration error. <br /><br />
| `false` |
| `faultTolerance` | SELECT, INSERT, REPLACE<br /><br /> Whether to turn on
fault tolerance mode or not. Failed workers are retried based on
[Limits](#limits). Cannot be used when `durableShuffleStorage` is explicitly
set to false.
| `false` |
| `selectDestination` | SELECT<br /><br /> Controls where the final result of
the select query is written. <br />Use `taskReport`(the default) to write
select results to the task report. <b> This is not scalable since task reports
size explodes for large results </b> <br/>Use `durableStorage` to write results
to durable storage location. <b>For large results sets, its recommended to use
`durableStorage` </b>. To configure durable storage see
[`this`](#durable-storage) section.
| `taskRep
ort` |
+| `segmentLoadWait` | INSERT, REPLACE<br /><br /> Whether the controller
should wait for segments to be loaded before exiting. If this is true, the
controller queries the broker and waits till the segments created (if any) have
been loaded by the load rules. The controller also provides this information in
the live reports and task reports. If this is false, the controller exits
immediately after finishing the query.
| `false` |
Review Comment:
seems very geared toward developers, and not the users. We can remove the
fact that it queries the broker (since that is an implementation detail).
WDYT of something along the lines:
```suggestion
| `segmentLoadWait` | INSERT, REPLACE<br /><br /> If set, the ingest query
waits for the generated segment to be loaded before exiting, else the ingest
query exits without waiting. The task and live reports contain the information
(about ??) if this flag is set. The drawback is that the tasks stall till the
segments are loaded, however ensures that... (advantage)
| `false` |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
