soumyava commented on code in PR #15086:
URL: https://github.com/apache/druid/pull/15086#discussion_r1347832029
##########
sql/src/test/resources/calcite/tests/window/no_grouping.sqlTest:
##########
@@ -3,7 +3,7 @@ type: "operatorValidation"
sql: |
SELECT
m1,
- COUNT(m1) OVER () cc
Review Comment:
Can we add a separate test if we are changing from COUNT to SUM
##########
sql/src/test/java/org/apache/druid/sql/calcite/QueryVerification.java:
##########
@@ -47,7 +47,12 @@ public QueryTestRunner.QueryVerifyStep
make(QueryTestRunner.BaseExecuteQuery exe
{
return () -> {
for (QueryTestRunner.QueryResults queryResults : execStep.results()) {
- verifier.verifyResults(queryResults);
+ try {
+ verifier.verifyResults(queryResults);
+ }
+ catch (Exception e) {
+ throw new RuntimeException("Exception during verification!", e);
Review Comment:
Can use a druid exception here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
