kfaraz commented on PR #15085: URL: https://github.com/apache/druid/pull/15085#issuecomment-1749933089
> I think it would be harder to figure out which action to use within the DruidInputSource. I guess the only case we care about is `CompactionTask`, where we can just the `TaskLockType` while constructing the `DruidInputSource`. If this input source is passed along to the sub tasks, the `DruidInputSource` deserialized in the sub tasks will know the lock type as well. The reason this would be preferable is the new action would just have to fetch the segments that the task is going to replace, i.e. segments belonging to the interval on which this task has a replace lock and which were created before the lock was acquired. It would avoid duplication and confusion with the existing action. Other cases: - Re-indexing from datasource A to B: None of the above applies, so we would just continue using the old action. - Re-indexing into the same datasource: Does this get launched as a `compact` task or a regular `index_parallel` task? If it is the latter, then while doing `REPLACE`, the submitted spec would need to declare `REPLACE` both in task context and in the io config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
