AmatyaAvadhanula commented on code in PR #15085:
URL: https://github.com/apache/druid/pull/15085#discussion_r1361458253
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -174,15 +174,76 @@ private Collection<DataSegment> doRetrieveUsedSegments(
}
@Override
- public List<Pair<DataSegment, String>>
retrieveUsedSegmentsAndCreatedDates(String dataSource)
+ public List<Pair<DataSegment, String>>
retrieveUsedSegmentsAndCreatedDates(String dataSource, Interval interval)
{
- String rawQueryString = "SELECT created_date, payload FROM %1$s WHERE
dataSource = :dataSource AND used = true";
- final String queryString = StringUtils.format(rawQueryString,
dbTables.getSegmentsTable());
+ StringBuilder queryBuilder = new StringBuilder(
+ "SELECT created_date, payload FROM %1$s WHERE dataSource = :dataSource
AND used = true"
+ );
+
+ final boolean intervalStartIsEternityStart =
Intervals.ETERNITY.getStart().equals(interval.getStart());
Review Comment:
This is important as such an interval may be passed to the method as an
argument.
Other methods in this class do not implement it as they assume that no
interval is passed when fetching segments for ETERNITY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
