abhishekagarwal87 commented on code in PR #15096:
URL: https://github.com/apache/druid/pull/15096#discussion_r1348460802
##########
sql/src/test/java/org/apache/druid/sql/calcite/NegativeTest.java:
##########
@@ -36,23 +37,52 @@
import static org.junit.Assert.assertThrows;
/**
- * Can be used to mark tests which are not-yet supported in decoupled mode.
+ * Can be used to mark tests which are not-yet supported for some reason.
+ *
+ * In case a testcase marked with this annotation fails - it means that the
+ * testcase no longer fails with the annotated expectation.
+ *
+ * During usage; the annotation process have to be added to the testclass.
+ * Ensure that it's loaded as the most outer-rule by using order=0 - otherwise
+ * it may interfere with other rules:
+ * <code>
+ * @Rule(order = 0)
+ * public NegativeTestProcessor decoupledIgnoreProcessor = new
NegativeTestProcessor();
+ *
+ * @NegativeTest
+ * @Test
+ * public void testA() {
+ * }
+ * </code>
*
- * In case a testcase marked with this annotation fails - it may mean that the
- * testcase no longer needs that annotation.
*/
@Retention(RetentionPolicy.RUNTIME)
@Target({ElementType.METHOD})
-public @interface DecoupledIgnore
+public @interface NegativeTest
Review Comment:
Both `FixMe` and `NotYetSupported` seem good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
