kfaraz commented on code in PR #15107:
URL: https://github.com/apache/druid/pull/15107#discussion_r1349611592
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -225,7 +225,14 @@ public TaskStatus runTask(TaskToolbox toolbox) throws
Exception
// Fetch the load specs of all segments overlapping with the given
interval
final Set<Map<String, Object>> usedSegmentLoadSpecs = toolbox
.getTaskActionClient()
- .submit(new RetrieveUsedSegmentsAction(getDataSource(),
getInterval(), null, Segments.INCLUDING_OVERSHADOWED))
+ .submit(new RetrieveUsedSegmentsAction(
Review Comment:
Format: would be easier to read if the unused intervals were pre-constructed
and the constructor was moved to a new line.
```suggestion
.submit(
new RetrieveUsedSegmentsAction(getDataSource(), null,
unusedIntervals, Segments.INCLUDING_OVERSHADOWED)
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
