cryptoe commented on code in PR #15059:
URL: https://github.com/apache/druid/pull/15059#discussion_r1349988518


##########
processing/src/main/java/org/apache/druid/query/spec/SpecificSegmentQueryRunner.java:
##########
@@ -74,7 +74,7 @@ public Sequence<T> run(final QueryPlus<T> input, final 
ResponseContext responseC
 
     final Thread currThread = setName ? Thread.currentThread() : null;
     final String currThreadName = setName ? currThread.getName() : null;
-    final String newName = setName ? query.getType() + "_" + 
query.getDataSource() + "_" + query.getIntervals() : null;
+    final String newName = setName ? "processing_" + 
query.getDataSource().getTableNames() + "_" + query.getId() : null;

Review Comment:
   > Is there any particular reason why are we removing the query type and 
setting it to processing_ now ? 
   So that stack traces reveal which queryID was blocking the execution pool. 
   
   > Honestly, I think it's fine to just set it to the Id and forget both the 
data source name and the query type.
   
   Thanks I reverted to my original commit. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to