clintropolis commented on code in PR #15059:
URL: https://github.com/apache/druid/pull/15059#discussion_r1351069584


##########
processing/src/main/java/org/apache/druid/query/spec/SpecificSegmentQueryRunner.java:
##########
@@ -74,7 +74,7 @@ public Sequence<T> run(final QueryPlus<T> input, final 
ResponseContext responseC
 
     final Thread currThread = setName ? Thread.currentThread() : null;
     final String currThreadName = setName ? currThread.getName() : null;
-    final String newName = setName ? query.getType() + "_" + 
query.getDataSource() + "_" + query.getIntervals() : null;
+    final String newName = setName ? "processing_" + query.getId() : null;

Review Comment:
   eh, i find it useful to be able to at a glance know query type and table 
name when looking at flame graphs, im not sure you can possibly know the table 
name now with this change without some external reference, though i suppose you 
can still tell the type by look into the flame graph...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to