abhishekagarwal87 commented on code in PR #15126:
URL: https://github.com/apache/druid/pull/15126#discussion_r1354514936


##########
services/src/main/java/org/apache/druid/server/AsyncQueryForwardingServlet.java:
##########
@@ -744,6 +749,8 @@ public void onComplete(Result result)
       }
       emitQueryTime(requestTimeNs, success, sqlQueryId, queryId);
 
+      AuthenticationResult authenticationResult = 
AuthorizationUtils.authenticationResultFromRequest(req);

Review Comment:
   this would throw an exception if DRUID_AUTHENTICATION_RESULT attribute is 
not set. can we not get the request directly and avoid possibility of that 
exception being thrown? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to