a2l007 commented on code in PR #15126:
URL: https://github.com/apache/druid/pull/15126#discussion_r1355992087
##########
services/src/main/java/org/apache/druid/server/AsyncQueryForwardingServlet.java:
##########
@@ -744,6 +749,8 @@ public void onComplete(Result result)
}
emitQueryTime(requestTimeNs, success, sqlQueryId, queryId);
+ AuthenticationResult authenticationResult =
AuthorizationUtils.authenticationResultFromRequest(req);
Review Comment:
Since we are [attaching an authenticator even if the authenticators are
null](https://github.com/apache/druid/blob/master/server/src/main/java/org/apache/druid/server/initialization/AuthenticatorMapperModule.java#L82),
I'd expect the request would have an auth result every time. The
QueryLifecycle also uses the same method and so if there were a failure, it
would fail before the request comes back to the router.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
