AmatyaAvadhanula commented on code in PR #15169:
URL: https://github.com/apache/druid/pull/15169#discussion_r1362357984
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -660,6 +662,18 @@ private Map<SegmentIdWithShardSpec,
SegmentIdWithShardSpec> upgradePendingSegmen
: overlappingPendingSegments.entrySet()) {
final SegmentIdWithShardSpec pendingSegmentId =
overlappingPendingSegment.getKey();
final String pendingSegmentSequence =
overlappingPendingSegment.getValue();
+
+ boolean considerSequence = false;
Review Comment:
Done
##########
server/src/main/java/org/apache/druid/indexing/overlord/IndexerMetadataStorageCoordinator.java:
##########
@@ -345,10 +345,12 @@ SegmentPublishResult commitReplaceSegments(
* </ul>
*
* @param replaceSegments Segments being committed by a REPLACE task
+ * @param activeBaseSequenceNames of base sequence names of active / pending
completion task groups of the supervisor
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
