adarshsanjeev commented on code in PR #15162:
URL: https://github.com/apache/druid/pull/15162#discussion_r1363207654
##########
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchHolderObjectStrategy.java:
##########
@@ -67,4 +74,32 @@ public HllSketchHolder fromByteBufferSafe(ByteBuffer buffer,
int numBytes)
)
);
}
+
+ private boolean isSafeToConvertToNullSketch(ByteBuffer buf)
+ {
+ // TODO: Might need a sanity check here, to ensure that position and
offset makes sense.
Review Comment:
Added a check here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
