gianm commented on PR #15162: URL: https://github.com/apache/druid/pull/15162#issuecomment-1780519338
FYI I benchmarked this patch on a dataset with 11 groups and a few million sketches going into those groups (so, each Union would get hundreds-of-thousands of calls). It's about 37% faster. ``` Query Status Iter Min Avg Median Max OK? watch_byuser_hll_12_4 200 25 454 463 461 511 Y [patch] watch_byuser_hll_12_4 200 25 622 636 636 665 Y [master] ``` I also tried the case where the number of groups and number of sketches is similar. In this case the patch is slightly slower. I think it's worth it on balance though. The speedup in the speedup case is a lot bigger than the slowdown in the slowdown case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
