kgyrtkirk commented on code in PR #15195:
URL: https://github.com/apache/druid/pull/15195#discussion_r1365016191
##########
sql/src/test/java/org/apache/druid/sql/calcite/NotYetSupported.java:
##########
@@ -88,7 +88,8 @@ enum Modes
INCORRECT_SYNTAX(DruidException.class, "Incorrect syntax near the
keyword"),
// at least c7 is represented oddly in the parquet file
T_ALLTYPES_ISSUES(AssertionError.class,
"(t_alltype|allTypsUniq|fewRowsAllData).parquet.*Verifier.verify"),
- RESULT_MISMATCH(AssertionError.class, "assertResultsEquals");
+ RESULT_MISMATCH(AssertionError.class, "assertResultsEquals"),
+ UNSUPPORTED_NULL_ORDERING(DruidException.class, "(A|DE)SCENDING ordering
with NULLS (LAST|FIRST)");
Review Comment:
Could be extended - but I don't really see the reason to do that right now:
as so far the exception message matching was enough - it at some point it will
need to optionally access some other things ; this can be extended/changed/etc
note that I don't want to give better access to these things from the
annotation `@NotYetSupported` either ; so that these enum entries are
more-or-less mandatory - so that they could also act as natural magnets for
similar issues :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
