kgyrtkirk commented on code in PR #15195:
URL: https://github.com/apache/druid/pull/15195#discussion_r1365717791
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java:
##########
@@ -14247,4 +14250,24 @@ public void
testLatestByOnStringColumnWithoutMaxBytesSpecified()
new Object[] {"abc", defaultString, "def", defaultString, "def",
defaultString}
));
}
+
+ @Test
+ public void testUnSupportedNullsFirst()
+ {
+ DruidException e = assertThrows(DruidException.class, () -> testBuilder()
+ .queryContext(ImmutableMap.of(PlannerContext.CTX_ENABLE_WINDOW_FNS,
true))
+ .sql("SELECT dim1,ROW_NUMBER() OVER (ORDER BY dim1 DESC NULLS FIRST)
from druid.foo")
+ .run());
+ assertEquals("DESCENDING ordering with NULLS FIRST is not supported!",
e.getMessage());
Review Comment:
change to use `invalidSqlIs()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
