This is an automated email from the ASF dual-hosted git repository.

amatya pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git


The following commit(s) were added to refs/heads/master by this push:
     new 5752a1a3831 Proper default for taskLockType in streaming ingestion 
(#15213)
5752a1a3831 is described below

commit 5752a1a3831d4f9dc181101e7ae0ebf10871385d
Author: Sébastien <[email protected]>
AuthorDate: Thu Oct 19 17:31:31 2023 +0200

    Proper default for taskLockType in streaming ingestion (#15213)
    
    * Proper value for taskLockType in streaming ingestion with concurrent 
compaction
---
 .../src/views/load-data-view/load-data-view.tsx      | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/web-console/src/views/load-data-view/load-data-view.tsx 
b/web-console/src/views/load-data-view/load-data-view.tsx
index 447a6379487..af39c2d0385 100644
--- a/web-console/src/views/load-data-view/load-data-view.tsx
+++ b/web-console/src/views/load-data-view/load-data-view.tsx
@@ -3178,8 +3178,24 @@ export class LoadDataView extends 
React.PureComponent<LoadDataViewProps, LoadDat
                   appendToExisting ? 'append' : 'replace'
                 } tasks (experimental)`,
                 defaultValue: undefined,
-                valueAdjustment: v => (v ? (appendToExisting ? 'APPEND' : 
'REPLACE') : undefined),
-                adjustValue: v => v === (appendToExisting ? 'APPEND' : 
'REPLACE'),
+                valueAdjustment: v => {
+                  if (!v) return undefined;
+
+                  if (isStreamingSpec(spec)) {
+                    return 'APPEND';
+                  } else {
+                    return appendToExisting ? 'APPEND' : 'REPLACE';
+                  }
+                },
+                adjustValue: v => {
+                  if (v === undefined) return false;
+
+                  if (isStreamingSpec(spec)) {
+                    return v === 'APPEND';
+                  }
+
+                  return v === (appendToExisting ? 'APPEND' : 'REPLACE');
+                },
                 info: <p>Allows or forbids concurrent tasks.</p>,
               },
             ]}


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to