YongGang commented on code in PR #15174:
URL: https://github.com/apache/druid/pull/15174#discussion_r1368982236
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -2113,7 +2113,13 @@ public Boolean
apply(Pair<SeekableStreamIndexTaskRunner.Status, Map<PartitionIdT
for (int i = 0; i < results.size(); i++) {
String taskId = futureTaskIds.get(i);
if (results.get(i).isError() || results.get(i).valueOrThrow() == null) {
- killTask(taskId, "Task [%s] failed to return status, killing task",
taskId);
+ log.info("Task [%s] failed to respond, might need to kill it.",
taskId);
+ Optional<TaskStatus> killTaskStatus = taskStorage.getStatus(taskId);
+ if (killTaskStatus.isPresent() && !killTaskStatus.get().isComplete()) {
+ // If the task completed while we were failing to chat with it,
don't do anything.
+ log.info("Task [%s] failed to return status, killing task", taskId);
Review Comment:
This log may be redundant as in `TaskRunner#shutdown` the reason has been
also logged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
