kgyrtkirk commented on code in PR #15241:
URL: https://github.com/apache/druid/pull/15241#discussion_r1374529038
##########
processing/src/main/java/org/apache/druid/query/operator/NaiveSortOperator.java:
##########
@@ -33,11 +34,11 @@
public class NaiveSortOperator implements Operator
{
private final Operator child;
- private final ArrayList<ColumnWithDirection> sortColumns;
+ private final List<ColumnWithDirection> sortColumns;
Review Comment:
* I think `ArrayList` have spread to a lot of places when these classes were
created
* its harder to test with `ArrayList` types on the interfaces...I didn't
wanted to go down further; I think wrapping stuff into the `ArrayList` when the
sorter is created should be rare enough
* intellij checks also encourages to use `Collections.singletonList` and
`emptyList` which are not `ArrayLists` either....
would you like to take an alternate approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
