clintropolis commented on code in PR #15241:
URL: https://github.com/apache/druid/pull/15241#discussion_r1375106261
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidOuterQueryRel.java:
##########
@@ -47,7 +47,7 @@
*/
public class DruidOuterQueryRel extends DruidRel<DruidOuterQueryRel>
{
- private static final TableDataSource DUMMY_DATA_SOURCE = new
TableDataSource("__subquery__");
+ public static final TableDataSource DUMMY_DATA_SOURCE = new
TableDataSource("__subquery__");
Review Comment:
i wonder if we should just override `isConcrete` to return false instead of
making this public and checking specifically for this (or maybe make a special
dummy datasource to use in planner that also implements isConcrete as false),
because we could simplify the scan query conversion to just check for
`!isConcrete` instead of checking for this instance or concrete
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidOuterQueryRel.java:
##########
@@ -47,7 +47,7 @@
*/
public class DruidOuterQueryRel extends DruidRel<DruidOuterQueryRel>
{
- private static final TableDataSource DUMMY_DATA_SOURCE = new
TableDataSource("__subquery__");
+ public static final TableDataSource DUMMY_DATA_SOURCE = new
TableDataSource("__subquery__");
Review Comment:
i wonder if we should just override `isConcrete` to return false instead of
making this public and checking specifically for this (or maybe make a special
dummy datasource to use in planner that also implements `isConcrete` as false),
because we could simplify the scan query conversion to just check for
`!isConcrete` instead of checking for this instance or concrete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
