abhishekagarwal87 commented on code in PR #15241:
URL: https://github.com/apache/druid/pull/15241#discussion_r1375415167
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidOuterQueryRel.java:
##########
@@ -47,7 +47,14 @@
*/
public class DruidOuterQueryRel extends DruidRel<DruidOuterQueryRel>
{
- private static final TableDataSource DUMMY_DATA_SOURCE = new
TableDataSource("__subquery__");
+ private static final TableDataSource DUMMY_DATA_SOURCE = new
TableDataSource("__subquery__")
+ {
+ @Override
+ public boolean isConcrete()
Review Comment:
should be helpful to have some comments associated with this override.
##########
processing/src/main/java/org/apache/druid/query/operator/NaiveSortOperator.java:
##########
@@ -33,11 +34,11 @@
public class NaiveSortOperator implements Operator
{
private final Operator child;
- private final ArrayList<ColumnWithDirection> sortColumns;
+ private final List<ColumnWithDirection> sortColumns;
Review Comment:
No. makes sense though that makes me wonder why not just do it for
NaiveSorter and its implementations too. So you don't have to create an
ArrayList at line 61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
