clintropolis opened a new pull request, #15366:
URL: https://github.com/apache/druid/pull/15366
### Description
Alternative mentioned in #15350, which is simplified and only matches a
single array element rather than being a full implementation of
'ARRAY_CONTAINS'. Decided to do this one when I realized that multi-value
dimensions would be handled incorrectly with the other filter when using array
type element matches.
Array element indexes are already hiding inside of array type columns, this
PR adds a native `arrayContainsElement` filter so we can actually use them to
implement things like `ARRAY_CONTAINS` (in this PR) and `ARRAY_OVERLAP` (not in
this PR).
No documentation currently added, will do that in a follow-up PR.
As expected, this is a giant perf improvement when using `ARRAY_CONTAINS` on
array columns. For the query added in the benchmarks:
```
SELECT string1, long1 FROM foo WHERE ARRAY_CONTAINS("multi-string3", 100)
GROUP BY 1,2
```
Before:
```
Benchmark (query) (rowsPerSegment) (schema)
(vectorize) Mode Cnt Score Error Units
SqlExpressionBenchmark.querySql 38 5000000 auto
false avgt 5 4839.508 ± 89.496 ms/op
```
After:
```
Benchmark (query) (rowsPerSegment) (schema)
(vectorize) Mode Cnt Score Error Units
SqlExpressionBenchmark.querySql 38 5000000 auto
false avgt 5 133.610 ± 3.750 ms/op
```
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
