clintropolis commented on code in PR #15366:
URL: https://github.com/apache/druid/pull/15366#discussion_r1408353491


##########
processing/src/main/java/org/apache/druid/query/filter/DimFilter.java:
##########
@@ -53,7 +53,8 @@
     @JsonSubTypes.Type(name = "equals", value = EqualityFilter.class),
     @JsonSubTypes.Type(name = "range", value = RangeFilter.class),
     @JsonSubTypes.Type(name = "isfalse", value = IsFalseDimFilter.class),
-    @JsonSubTypes.Type(name = "istrue", value = IsTrueDimFilter.class)
+    @JsonSubTypes.Type(name = "istrue", value = IsTrueDimFilter.class),
+    @JsonSubTypes.Type(name = "arrayContainsElement", value = 
ArrayContainsElementFilter.class)

Review Comment:
   I didn't want to confuse this native filter with the array_contains function 
which this filter can be used to implement but doesn't completely implement 
(see PR description), so I'd prefer to leave it like this to avoid confusion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to