adarshsanjeev commented on code in PR #15368:
URL: https://github.com/apache/druid/pull/15368#discussion_r1392774064
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -370,7 +373,7 @@ public void stopGracefully()
);
if (workerTaskLauncher != null) {
- workerTaskLauncher.waitForWorkerShutdown();
+ workerTaskLauncher.stop(true);
Review Comment:
`waitForWorkerShutdown` might still be needed The closer to wait for cancel
to be sent to all tasks, since the closer also cleans up the overlord client
after this call, causing the reverse problem of workers running without the
controller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
